Ubuntu
nix package

Merge ~vpa1977/ubuntu/+source/nix:ftbfs into ubuntu/+source/nix:ubuntu/devel

  1. Git
  2. lp:~vpa1977/ubuntu/+source/nix
  3. ftbfs
  4. Merge into ubuntu/devel
Proposed by Vladimir Petko
Status: Needs review
Proposed branch: ~vpa1977/ubuntu/+source/nix:ftbfs
Merge into: ubuntu/+source/nix:ubuntu/devel
Diff against target: 67 lines (+18/-9)
3 files modified
debian/changelog (+7/-0)
debian/control (+3/-1)
debian/tests/control (+8/-8)
Reviewer Review Type Date Requested Status
Dave Jones (community) Approve
git-ubuntu import Pending
Review via email: mp+452708@code.qastaging.launchpad.net

Description of the change

Changes:
 - add missing libssh-dev dependency
 - disable autopkgtests requiring internet access

PPA: ppa:vpa1977/plusone[1]

Tests:
 - autopkgtests:
 nix/2.16.1+dfsg-3ubuntu1~ppa4
    + ✅ nix on mantic for amd64 @ 05.10.23 22:02:36 Log️ 🗒️
    + ✅ nix on mantic for arm64 @ 05.10.23 22:04:03 Log️ 🗒️
    + ✅ nix on mantic for armhf @ 05.10.23 22:02:56 Log️ 🗒️
    + ✅ nix on mantic for ppc64el @ 05.10.23 22:02:12 Log️ 🗒️
    + ✅ nix on mantic for s390x @ 05.10.23 22:00:54 Log️ 🗒️
- piuparts test
1m9.5s INFO: PASS: All tests.
1m9.5s INFO: piuparts run ends. [2]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/plusone/+packages
[2] https://bugs.launchpad.net/ubuntu/+source/nix/+bug/2037314/+attachment/5707227/+files/nix.log.gz

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Why is this not a problem in debian? The ubuntu package is a sync.

I was trying to do a debian build on sid, but this package is nasty, it killed my laptop with what looked like an unbounded "make -j".

Reply
Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ):

> Why is this not a problem in debian? The ubuntu package is a sync.
The internet enabled tests are not a problem in Debian since they allow autopkgtests to access internet. For me they failed with download timeouts even after adding "needs-internet" tag. The failures may have been due to the infrastructure issues on our side. I probably need to check with QA team if disabling them was necessary.
>
> I was trying to do a debian build on sid, but this package is nasty, it killed
> my laptop with what looked like an unbounded "make -j".

Debian curl version is 8.3.0-2 and it provides following package configuration:
``
Libs.private: -lnghttp2 -lidn2 -lrtmp -lssh2 -lssh2 -lpsl -lnettle -lgnutls -lgssapi_krb5 -llber -lldap -llber -lzstd -lbrotlidec -lz

``
It links with ssh2 (which is already a dependency), where as Ubuntu curl is 8.2.1-1ubuntu3 and links with ssh.

In order to build the nix package in Ubuntu, I had to explicitly add ssh dependency.

Reply
Revision history for this message
Dave Jones (waveform) wrote :

Okay, this looks reasonable at this point, and I think both of Andreas' points have been addressed. It may be worth pushing the "needs-internet" changes up to Debian at least (though they won't change anything up there, it won't harm anything and would reduce our future delta). In the meantime I'll sponsor this.

review: Approve
Reply

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches