Code review comment for ~vpa1977/ubuntu/+source/visualvm:2.1.6upgrade

Revision history for this message
Dave Jones (waveform) wrote :

>> Looks largely fine, but the version number in the changelog looks wrong?
> Since we are uploading the package before Debian, we need to make sure that the original tarball can be replaced by the Debian version, hence ~us1 suffix to indicate the Ubuntu-specific repack.
> This was suggested some time ago when I made a mistake with openjdk original tarball, e.g. see[1]

Ah, that makes sense, thanks for the explanation! Thanks for checking uscan produces the same output -- that gives us more confidence we're likely to be uploading what Debian will be in future. Still, the ~us1 suffix makes a lot of sense to me now, and it's better to be safe than sorry so I'll strip the top commit off here, and upload with that suffix in place. Just in case!

review: Approve

« Back to merge proposal