Merge ~vpa1977/ubuntu/+source/visualvm:2.1.6upgrade into ubuntu/+source/visualvm:ubuntu/devel

Proposed by Vladimir Petko
Status: Needs review
Proposed branch: ~vpa1977/ubuntu/+source/visualvm:2.1.6upgrade
Merge into: ubuntu/+source/visualvm:ubuntu/devel
Prerequisite: ~vpa1977/ubuntu/+source/visualvm:new-upstream2.1.6
Diff against target: 136 lines (+33/-46)
5 files modified
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/patches/org.openide.util.lookup.patch (+22/-4)
debian/patches/series (+0/-1)
dev/null (+0/-40)
Reviewer Review Type Date Requested Status
Dave Jones Pending
git-ubuntu import Pending
Review via email: mp+447222@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2023-07-17.

Description of the change

Update VisualVM to the latest version in mantic.

Summary of changes:
   * VisualVM release 2.1.6 (LP: #2026700).
    - Release notes: https://visualvm.github.io/relnotes.html.
  * d/p/JDK17-FTBFS.patch: dropped as it is no longer needed.
  * d/p/org.openide.util.lookup.patch: refresh patch.

PPA: ppa:vpa1977/visualvm [1]

Testing:
   1) upgrade/install/remove package (see comment)
   2) Basic functionality:
     $sudo snap install eclipse --classic
     $visualvm
    check that eclipse appears in the visualvm tree and tabs with VM information are populated

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/visualvm

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) : Posted in a previous version of this proposal
Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ): Posted in a previous version of this proposal

I have tried to add more openjdk versions to the launcher patch, but visualvm itself crashes with security manager exception when running under openjdk-20. I have left launcher patch unchanged.

Revision history for this message
Vladimir Petko (vpa1977) wrote : Posted in a previous version of this proposal
Download full text (6.4 KiB)

Basic testing:

Package install:

---------------------------cut-----------------------
apt install visualvm
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  visualvm
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 4202 kB of archives.
After this operation, 21.8 MB of additional disk space will be used.
Get:1 https://ppa.launchpadcontent.net/vpa1977/visualvm/ubuntu mantic/main amd64 visualvm all 2.1.6~us1-0ubuntu1~ppa3 [4202 kB]
Fetched 4202 kB in 13s (332 kB/s)
Selecting previously unselected package visualvm.
(Reading database ... 34879 files and directories currently installed.)
Preparing to unpack .../visualvm_2.1.6~us1-0ubuntu1~ppa3_all.deb ...
Unpacking visualvm (2.1.6~us1-0ubuntu1~ppa3) ...
Setting up visualvm (2.1.6~us1-0ubuntu1~ppa3) ...
Processing triggers for hicolor-icon-theme (0.17-2) ...
------------------------------------------cut----------

Package removal:
------------------------------------------cut----------
apt remove visualvm
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages were automatically installed and are no longer required:
  adwaita-icon-theme alsa-topology-conf alsa-ucm-conf ant ant-optional antlr3 at-spi2-common at-spi2-core ca-certificates-java dconf-gsettings-backend dconf-service default-jdk default-jdk-headless default-jre default-jre-headless
  fontconfig fontconfig-config fonts-dejavu-core fonts-dejavu-extra gsettings-desktop-schemas gtk-update-icon-cache hicolor-icon-theme humanity-icon-theme java-common javahelp2 junit4 libantlr-java libantlr3-runtime-java
  libapache-pom-java libasm-java libasound2 libasound2-data libatk-bridge2.0-0 libatk-wrapper-java libatk-wrapper-java-jni libatk1.0-0 libatspi2.0-0 libavahi-client3 libavahi-common-data libavahi-common3 libbsh-java
  libcairo-gobject2 libcairo2 libcommons-codec-java libcommons-io-java libcommons-logging-java libcommons-parent-java libcups2 libdatrie1 libdconf1 libdeflate0 libdrm-amdgpu1 libdrm-common libdrm-intel1 libdrm-nouveau2
  libdrm-radeon1 libdrm2 libequinox-osgi-java libfelix-framework-java libfelix-main-java libfontconfig1 libfontenc1 libfreetype6 libgail-common libgail18 libgdk-pixbuf-2.0-0 libgdk-pixbuf2.0-bin libgdk-pixbuf2.0-common libgif7
  libgl1 libgl1-amber-dri libgl1-mesa-dri libglapi-mesa libglvnd0 libglx-mesa0 libglx0 libgraphite2-3 libgtk2.0-0 libgtk2.0-bin libgtk2.0-common libhamcrest-java libharfbuzz0b libice-dev libice6 libjbig0 libjcommander-java
  libjna-java libjna-jni libjna-platform-java libjpeg-turbo8 libjpeg8 libjson-simple-java libjsr305-java liblcms2-2 liblerc4 libllvm15 libnb-org-openide-modules-java libnb-org-openide-util-java libnb-org-openide-util-lookup-java
  libnb-platform18-java libnspr4 libnss3 libosgi-annotation-java libosgi-compendium-java libosgi-core-java libpango-1.0-0 libpangocairo-1.0-0 libpangoft2-1.0-0 libpciacce...

Read more...

Revision history for this message
Dave Jones (waveform) wrote : Posted in a previous version of this proposal

Looks largely fine, but the version number in the changelog looks wrong?

review: Needs Fixing
Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ): Posted in a previous version of this proposal

> Looks largely fine, but the version number in the changelog looks wrong?
Since we are uploading the package before Debian, we need to make sure that the original tarball can be replaced by the Debian version, hence ~us1 suffix to indicate the Ubuntu-specific repack.
This was suggested some time ago when I made a mistake with openjdk original tarball, e.g. see[1]

[1] https://launchpad.net/ubuntu/+source/openjdk-17/+publishinghistory

Revision history for this message
Vladimir Petko (vpa1977) wrote : Posted in a previous version of this proposal

checked re-downloading original tarball with uscan - no differences introduced by the repack, so removed the suffix.

Revision history for this message
Dave Jones (waveform) wrote : Posted in a previous version of this proposal

>> Looks largely fine, but the version number in the changelog looks wrong?
> Since we are uploading the package before Debian, we need to make sure that the original tarball can be replaced by the Debian version, hence ~us1 suffix to indicate the Ubuntu-specific repack.
> This was suggested some time ago when I made a mistake with openjdk original tarball, e.g. see[1]

Ah, that makes sense, thanks for the explanation! Thanks for checking uscan produces the same output -- that gives us more confidence we're likely to be uploading what Debian will be in future. Still, the ~us1 suffix makes a lot of sense to me now, and it's better to be safe than sorry so I'll strip the top commit off here, and upload with that suffix in place. Just in case!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches