Merge lp://qastaging/~vrruiz/cordova-ubuntu-tests/ap-better-reporting into lp://qastaging/cordova-ubuntu-tests

Proposed by Víctor R. Ruiz
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 29
Merged at revision: 25
Proposed branch: lp://qastaging/~vrruiz/cordova-ubuntu-tests/ap-better-reporting
Merge into: lp://qastaging/cordova-ubuntu-tests
Diff against target: 806 lines (+159/-91)
26 files modified
tests/autopilot/cordova_ubuntu/tests/__init__.py (+30/-12)
tests/autopilot/cordova_ubuntu/tests/test_mobilespec.py (+37/-26)
tests/autopilot/tools/qml/main-local.qml (+1/-1)
www/autotest/html/JUnitXmlReporter.js (+5/-5)
www/autotest/pages/accelerometer.html (+2/-2)
www/autotest/pages/all.html (+3/-3)
www/autotest/pages/battery.html (+2/-2)
www/autotest/pages/bridge.html (+2/-2)
www/autotest/pages/camera.html (+2/-2)
www/autotest/pages/capture.html (+2/-2)
www/autotest/pages/compass.html (+2/-2)
www/autotest/pages/contacts.html (+2/-2)
www/autotest/pages/datauri.html (+2/-2)
www/autotest/pages/device.html (+2/-2)
www/autotest/pages/file.html (+4/-4)
www/autotest/pages/filetransfer.html (+4/-4)
www/autotest/pages/geolocation.html (+2/-2)
www/autotest/pages/globalization.html (+2/-2)
www/autotest/pages/media.html (+2/-2)
www/autotest/pages/network.html (+2/-2)
www/autotest/pages/notification.html (+2/-2)
www/autotest/pages/platform.html (+2/-2)
www/autotest/pages/splashscreen.html (+2/-2)
www/autotest/pages/storage.html (+2/-2)
www/autotest/pages/whitelist.html (+2/-2)
www/autotest/test-runner.js (+39/-0)
To merge this branch: bzr merge lp://qastaging/~vrruiz/cordova-ubuntu-tests/ap-better-reporting
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Review via email: mp+191177@code.qastaging.launchpad.net

Commit message

Skip unsupported API tests.

Description of the change

Skip unsupported API tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

What is the purpose of get_www_dir_path? Unlike get_{cordova_container,persistent}_path, it returns the same value regardless of what happens in the if statement, making it useless. Do you intend to do something about the www dir not existing? It should be guaranteed to exist due to the dependencies of the deb package. Please drop that function and reference self.WWW_DIR_PATH wherever you would call self.get_www_dir_path() from.

review: Needs Fixing
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Robert: To be able to run the tests on the development branch, wherever the developer is working.

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Robert: Ok, checked carefully and that method is not used anymore. Removed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Thanks Victor! Looks good now ;-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches