gallery-app

Merge lp://qastaging/~vrruiz/gallery-app/test-share-photo into lp://qastaging/gallery-app

test-share-photo
Merge into trunk

Proposed by Víctor R. Ruiz on 2014-07-08

Status:

Superseded

Proposed branch:

lp://qastaging/~vrruiz/gallery-app/test-share-photo

Merge into:

lp://qastaging/gallery-app

Diff against target:

284 lines (+242/-0)

4 files modified

debian/control (+2/-0)
tests/autopilot/gallery_app/credentials.py (+117/-0)
tests/autopilot/gallery_app/emulators/photo_viewer.py (+18/-0)
tests/autopilot/gallery_app/tests/test_share.py (+105/-0)

To merge this branch:

bzr merge lp://qastaging/~vrruiz/gallery-app/test-share-photo

Undecided

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-07-16
Leo Arias (community)	code review	2014-07-14	Needs Fixing on 2014-07-14
Ubuntu Phablet Team		2014-07-08	Pending
Review via email: mp+225947@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-07-16.

Commit message

Autopilot: Test for share photo.

Description of the change

Autopilot: Test for share photo.

Revision history for this message

Víctor R. Ruiz (vrruiz) wrote on 2014-07-08:

Work in progress (there is a problem with Friends and python-dbusmock).

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/890/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~vrruiz/gallery-app/test-share-photo updated on 2014-07-14

1006. By Víctor R. Ruiz on 2014-07-09: Autopilot: Fix dbus object names
1007. By Víctor R. Ruiz on 2014-07-14: Autopilot: Create fake Facebook account to share photos

Revision history for this message

Víctor R. Ruiz (vrruiz) wrote on 2014-07-14:

Ready for review.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/903/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~vrruiz/gallery-app/test-share-photo updated on 2014-07-14

1008. By Víctor R. Ruiz on 2014-07-14: Dependency for autopilot tests - python3-dbusmock

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/909/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-14:

202 + def post_button(self):
214 + def do_share_photo(self):
206 + def share_panel(self):

These shouldn't be part of the test case. They should be custom proxy objects or used in methods of the parent custom proxy object.

43 +class AccountManager(object):
159 +class FakeFriendsService(object):

Please talk with Richard and Brendan. They are working with the devs to move a fake dbus service like this one to the right project. In their case URLDispatcher, in your case the friends service. We agreed that it's ok to duplicate the code in the project like you are doing here just if we are working at the same time to put it in the right place. Maybe one of them can help you talking with your devs to see how easy would it be to get this done in the right way.

254 + sleep(5)

You should use Eventually instead of a sleep.

249 + def test_facebook(self):

You need a better name for this test. Something like test_share_with_facebook_must_call_friends_service.

Finally, all your FIXMEs look really weird. I don't understand how you are creating the account without starting the main loop, as it's asynchronous. It seems though that you don't need to store any credentials, just create the account. That's really nice, you can probably remove a lot of the code in Account Manager. If you can get mardy to help you with this it would be great. If not, maybe I can give you a hand later on the week.

Thanks Victor. This test is great.

review: Needs Fixing (code review)

lp://qastaging/~vrruiz/gallery-app/test-share-photo updated on 2014-07-16

1009. By Víctor R. Ruiz on 2014-07-16: Autopilot: test_share refactor
1010. By Víctor R. Ruiz on 2014-07-16: Missing dependency

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-16:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/915/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-16:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/916/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1010. By Víctor R. Ruiz on 2014-07-16: Missing dependency
1009. By Víctor R. Ruiz on 2014-07-16: Autopilot: test_share refactor
1008. By Víctor R. Ruiz on 2014-07-14: Dependency for autopilot tests - python3-dbusmock
1007. By Víctor R. Ruiz on 2014-07-14: Autopilot: Create fake Facebook account to share photos
1006. By Víctor R. Ruiz on 2014-07-09: Autopilot: Fix dbus object names
1005. By Víctor R. Ruiz on 2014-06-23: Autopilot: Move UI code to helper function
1004. By Víctor R. Ruiz on 2014-06-23: Autopilot: Fix dbus path
1003. By Víctor R. Ruiz on 2014-06-20: Fix typos
1002. By Víctor R. Ruiz on 2014-06-20: Autopilot: Test for share photo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Ubuntu Phablet Team

Víctor R. Ruiz