Merge lp://qastaging/~vthompson/dropping-letters/fix-1350560 into lp://qastaging/dropping-letters
Proposed by
Victor Thompson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Alan Pope 🍺🐧🐱 🦄 | ||||
| Approved revision: | 68 | ||||
| Merged at revision: | 67 | ||||
| Proposed branch: | lp://qastaging/~vthompson/dropping-letters/fix-1350560 | ||||
| Merge into: | lp://qastaging/dropping-letters | ||||
| Diff against target: |
84 lines (+5/-10) 1 file modified
dropping-letters.qml (+5/-10) |
||||
| To merge this branch: | bzr merge lp://qastaging/~vthompson/dropping-letters/fix-1350560 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Only play sound if sound is on
Description of the change
Currently, it seems as though the Audio.muted property is not allowing the app to actually mute the playback. In either case, it would be smarter to not even play the sound effects if sound is off anyway.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:68
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://