Merge lp://qastaging/~vthompson/dropping-letters/fix-1366586-dropping-letters into lp://qastaging/dropping-letters

Proposed by Victor Thompson
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 60
Merged at revision: 61
Proposed branch: lp://qastaging/~vthompson/dropping-letters/fix-1366586-dropping-letters
Merge into: lp://qastaging/dropping-letters
Diff against target: 35 lines (+4/-0)
1 file modified
dropping-letters.qml (+4/-0)
To merge this branch: bzr merge lp://qastaging/~vthompson/dropping-letters/fix-1366586-dropping-letters
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan (community) Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+234559@code.qastaging.launchpad.net

Commit message

Categorize Audio type

Description of the change

Dropping letters does not currently play audio (see lp:1368998) but once that is fixed, the audio category of the sound effects will need to be set.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Tests pass fine on desktop here...

alan@deep-thought:/tmp/fix-1366586-dropping-letters/tests/autopilot$ autopilot run dropping_letters_app
Loading tests from: /tmp/fix-1366586-dropping-letters/tests/autopilot

Tests running...

Ran 3 tests in 16.515s
OK

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Not quite sure what's going on here..

The following packages have unmet dependencies:
 dropping-letters : Depends: qtdeclarative5-hud1.0 but it is not installable
E: Unable to correct problems, you have held broken packages.

Later..

could not import package dropping_letters_app: No module named 'dropping_letters_app'

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

lgtm!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches