Merge lp://qastaging/~vthompson/dropping-letters/pause-button into lp://qastaging/dropping-letters

Proposed by Victor Thompson
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 64
Merged at revision: 63
Proposed branch: lp://qastaging/~vthompson/dropping-letters/pause-button
Merge into: lp://qastaging/dropping-letters
Diff against target: 1991 lines (+21/-1875)
8 files modified
apparmor/dropping-letters.json (+1/-1)
audio-volume-high-symbolic.svg (+0/-112)
audio-volume-high.svg (+0/-645)
audio-volume-muted-symbolic.svg (+0/-115)
audio-volume-muted.svg (+0/-993)
debian/install (+0/-6)
dropping-letters.qml (+19/-2)
manifest.json (+1/-1)
To merge this branch: bzr merge lp://qastaging/~vthompson/dropping-letters/pause-button
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+234579@code.qastaging.launchpad.net

Commit message

* Add a pause/resume button
* Remove unused icons

Description of the change

This change adds a pause/resume button to the toolbar. It also removes some of the old icons that were manually included. Instead, the app should use the icons already on the device via iconName.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Great, thanks :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches