Ubuntu Music App

Merge lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 into lp://qastaging/music-app

  1. music-uc1.3-now-playing-fix-1447428
  2. Merge into trunk
Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 915
Merged at revision: 939
Proposed branch: lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428
Merge into: lp://qastaging/music-app
Prerequisite: lp://qastaging/~vthompson/music-app/music-uc1.3
Diff against target: 427 lines (+87/-70)
5 files modified
app/music-app.qml (+3/-9)
app/ui/NowPlaying.qml (+25/-10)
debian/changelog (+1/-0)
po/com.ubuntu.music.pot (+51/-47)
tests/autopilot/music_app/__init__.py (+7/-4)
To merge this branch: bzr merge lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+275635@code.qastaging.launchpad.net

Commit message

* Add initial page sections to Now Playing view

Description of the change

* Add initial page sections to Now Playing view

This adds a Now Playing toggle to the Now Playing view, using the newer Page Head Sections API. This has been approved by Design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:908
http://91.189.93.70:8080/job/music-app-ci/1399/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/251

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1399/rebuild

review: Approve (continuous-integration)
lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
909. By Victor Thompson

Merge trunk and resolve conflicts.

910. By Victor Thompson

Add FIXME.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:910
http://91.189.93.70:8080/job/music-app-ci/1411/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/263

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1411/rebuild

review: Approve (continuous-integration)
lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
911. By Victor Thompson

Merge trunk and resolve conflicts.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:911
http://91.189.93.70:8080/job/music-app-ci/1414/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/266

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1414/rebuild

review: Approve (continuous-integration)
lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
912. By Victor Thompson

Fix AP.

Revision history for this message
Victor Thompson (vthompson) wrote :

Tests running...

Ran 19 tests in 259.503s
OK

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:912
http://91.189.93.70:8080/job/music-app-ci/1415/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/267

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1415/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

One inline comment

review: Needs Information
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Also would be really really nice if we could centre align the head sections, wonder if that is something we can request?

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

When you switch from the Queue -> Full View I think it should set the state back to normal, so that it disables any multiselects that have happened.

Revision history for this message
Victor Thompson (vthompson) wrote :

As for centering the sections, we should talk to the SDK and Design teams to see how they envision apps making this visible. I assumed having them left justified was preferred, but for something like this (a view toggle) centering the section items seems like a decent idea.

lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
913. By Victor Thompson

Remove onVisibleChanged and add code to close multiselection.

Revision history for this message
Victor Thompson (vthompson) wrote :

I'm not sure why I added the onVisibleChanged handler. I've removed it to fix the playlist add issue. I've also made it so multiselect will be close when toggling.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:913
http://91.189.93.70:8080/job/music-app-ci/1416/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/268

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1416/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

#blocked on lp:1511839 landing in ota8

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

One inline comment, if pushNowPlaying() is called, it needs to be ensured that the Full View is selected as this could be called via uri-handler but in the queue view.

review: Needs Fixing
lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
914. By Victor Thompson

Resolve comment.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, nice to make use of the new uc1.3 components and get rid of the confusing/ambiguous header action :-)

review: Approve
lp://qastaging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428 updated
915. By Victor Thompson

Merge trunk and resolve conflict

Revision history for this message
Victor Thompson (vthompson) wrote :

Tests running...
/usr/lib/python3/dist-packages/gi/overrides/Gtk.py:1554: Warning: g_object_ref: assertion 'G_IS_OBJECT (object)' failed
  initialized, argv = Gtk.init_check(sys.argv)

Ran 19 tests in 242.214s
OK

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches