Ubuntu Music App

Merge lp://qastaging/~vthompson/music-app/music-uc1.3-sort-songs into lp://qastaging/music-app

  1. music-uc1.3-sort-songs
  2. Merge into trunk
Proposed by Victor Thompson
Status: Work in progress
Proposed branch: lp://qastaging/~vthompson/music-app/music-uc1.3-sort-songs
Merge into: lp://qastaging/music-app
Prerequisite: lp://qastaging/~vthompson/music-app/music-uc1.3
Diff against target: 294 lines (+67/-41)
3 files modified
app/ui/Songs.qml (+17/-0)
debian/changelog (+1/-0)
po/com.ubuntu.music.pot (+49/-41)
To merge this branch: bzr merge lp://qastaging/~vthompson/music-app/music-uc1.3-sort-songs
Reviewer Review Type Date Requested Status
Andrew Hayzen Needs Information
Victor Thompson Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+275634@code.qastaging.launchpad.net

Commit message

* Use Page Head Section to allow Songs tab to be sorted.

Description of the change

* Use Page Head Section to allow Songs tab to be sorted.

The related bug [1] has initial approval for using these Sections in the Now Playing view. This change allows the Songs tab to be sorted by date added.

1 - https://bugs.launchpad.net/music-app/+bug/1447428

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:908
http://91.189.93.70:8080/job/music-app-ci/1398/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/250

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1398/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Using this in the 'root' pages could be problematic when the convergence stuff lands [2] as it uses the head sections instead of tabs. As we would then have double sections it would look a bit weird, I think header actions would be preferable here.

1 - https://code.launchpad.net/~ahayzen/music-app/refactor-adaptive-page-layout

review: Needs Information
Reply
Revision history for this message
Victor Thompson (vthompson) wrote :

Agreed, since the converged view will use the sections for the different tabs/views we should find a different pattern for the sorting options.

review: Needs Fixing
Reply
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

My suggestion is:
Create a header action called "Sort..." then use a popup (like the one in the webbrowser when you press and hold a link) that gives the options "Alphabetical", "Date added" etc.

review: Needs Information
Reply

Unmerged revisions

908. By Victor Thompson

* Use Page Head Section to allow Songs tab to be sorted.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches