Merge lp://qastaging/~vthompson/music-app/remix-music-splash into lp://qastaging/music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 650
Merged at revision: 650
Proposed branch: lp://qastaging/~vthompson/music-app/remix-music-splash
Merge into: lp://qastaging/music-app/remix
Diff against target: 11 lines (+3/-0)
1 file modified
com.ubuntu.music_music.desktop.in.in (+3/-0)
To merge this branch: bzr merge lp://qastaging/~vthompson/music-app/remix-music-splash
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+237193@code.qastaging.launchpad.net

Commit message

Used new desktop entries to show a fake application page during the startup.

Description of the change

Used new desktop entries to show a fake application page during the startup.

To test I had to manually copy the desktop file that was deployed to ~/.local/share/applications:

cp /opt/click.ubuntu.com/.click/users/phablet/com.ubuntu.music/com.ubuntu.music_music.desktop /home/phablet/.local/share/applications/com.ubuntu.music_music_1.3.649.desktop

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, I wonder if we should remove the "Loading..." or change it so it appears the same as the SDK loading in the future?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches