Merge lp://qastaging/~vthompson/ubuntu-terminal-app/backspace-and-enter-workaround into lp://qastaging/ubuntu-terminal-app

Proposed by Victor Thompson
Status: Rejected
Rejected by: Nicholas Skaggs
Proposed branch: lp://qastaging/~vthompson/ubuntu-terminal-app/backspace-and-enter-workaround
Merge into: lp://qastaging/ubuntu-terminal-app
Diff against target: 25 lines (+16/-0)
1 file modified
extraPanel/ScrlKeys.qml (+16/-0)
To merge this branch: bzr merge lp://qastaging/~vthompson/ubuntu-terminal-app/backspace-and-enter-workaround
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+200204@code.qastaging.launchpad.net

Commit message

Work around for Backspace and Enter keys not working.

Description of the change

Work around for Backspace and Enter keys not working.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I'm not sure how I feel about this, but I suppose it could be deemed better than broken..

34. By Victor Thompson

Merge trunk and fix button text for ENTER and BACKSPACE

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Rejecting, as a proper fix has landed.

review: Disapprove

Unmerged revisions

34. By Victor Thompson

Merge trunk and fix button text for ENTER and BACKSPACE

33. By Victor Thompson

Work around for Backspace and Enter keys not working

32. By Victor Thompson

Start app in user's home directory. Fixes: https://bugs.launchpad.net/bugs/1239089.

Approved by Michael Hall, Ubuntu Phone Apps Jenkins Bot.

31. By Victor Thompson

Exit the application when session is finished (exit command is entered).

Approved by Michael Hall, Ubuntu Phone Apps Jenkins Bot.

30. By Sam Hewitt

New icon following the icon design guidelines.

Approved by Ubuntu Phone Apps Jenkins Bot, David Planella.

29. By Nicholas Skaggs

Disable color scheme test.

Approved by Ubuntu Phone Apps Jenkins Bot.

28. By Omer Akram

* simplify the extra panel widgets code.
* Add 1gu top margin for extra panels
* extra panel button text is now in center of the button.

Approved by Ubuntu Phone Apps Jenkins Bot, Nicholas Skaggs.

27. By Sergio Schvezov

Removing obsolete encoding from desktop. Adding plugins.json to track the embedded plugins used.

Approved by Ubuntu Phone Apps Jenkins Bot, Alan Pope ㋛.

26. By Sergio Schvezov

Upstreaming click support.

Approved by Ubuntu Phone Apps Jenkins Bot, Alan Pope ㋛.

25. By Nicholas Skaggs

update the hardcoded db path so autopilot tests can continue to work. Fixes: https://bugs.launchpad.net/bugs/1234544.

Approved by Ubuntu Phone Apps Jenkins Bot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches