Merge lp://qastaging/~vthompson/ubuntu-weather-app/fix-1452501-location-not-found into lp://qastaging/ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 91
Merged at revision: 95
Proposed branch: lp://qastaging/~vthompson/ubuntu-weather-app/fix-1452501-location-not-found
Merge into: lp://qastaging/ubuntu-weather-app
Diff against target: 145 lines (+56/-22)
4 files modified
app/ui/AddLocationPage.qml (+24/-22)
debian/changelog (+1/-0)
tests/autopilot/ubuntu_weather_app/__init__.py (+7/-0)
tests/autopilot/ubuntu_weather_app/tests/test_add_location_page.py (+24/-0)
To merge this branch: bzr merge lp://qastaging/~vthompson/ubuntu-weather-app/fix-1452501-location-not-found
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+267602@code.qastaging.launchpad.net

Commit message

* Create autopilot test for no locations found from search

Description of the change

* Create autopilot test for no locations found from search

I also fixed the indentation of some of the code in AddLocationPage.qml

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
91. By Victor Thompson

Merge and resolve conflicts

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: