Merge lp://qastaging/~wallyworld/launchpadlib/services-serviceroot into lp://qastaging/launchpadlib
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Colin Watson | ||||
| Proposed branch: | lp://qastaging/~wallyworld/launchpadlib/services-serviceroot | ||||
| Merge into: | lp://qastaging/launchpadlib | ||||
| Diff against target: |
225 lines (+118/-4) 7 files modified
.bzrignore (+1/-0) src/launchpadlib/NEWS.txt (+5/-0) src/launchpadlib/__init__.py (+1/-1) src/launchpadlib/docs/toplevel.txt (+8/-0) src/launchpadlib/launchpad.py (+14/-1) src/launchpadlib/testing/testing-wadl.xml (+75/-0) src/launchpadlib/testing/tests/test_launchpad.py (+14/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~wallyworld/launchpadlib/services-serviceroot | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Collins (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Add top level services collection to enable easy access to named Launchpad services.
Description of the change
== Implementation ==
This branch adds a new top level 'services' collection, allowing easy access to named Launchpad services. A Launchpad service implements IService and is traversed to via +service/<name>
Using launchpadlib:
lp = Launchpad(...)
service = lp.services[
service.
Some drive-by lint was also done.
== Tests ==
Extend the testing-wadl.xml file and add a new test test_services_
The test simply ensures the new ServiceSet class is properly setup allowing the services top level collection to be used to locate a service.
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
.bzrignore
src/launchpad
src/launchpad
src/launchpad
src/launchpad
src/launchpad
src/launchpad
./src/launchpad
121: want exceeds 78 characters.
| Ian Booth (wallyworld) wrote | # |
| Colin Watson (cjwatson) wrote | # |
This seems to special case all the services; if the bug about interface support in launchpadlib were fixed, it wouldn't need special casing. As it stands, this is adding code rather than maintaining LoC count, and doing so when a generic approach will be ~ the same size and much more powerful doesn't make sense.