Merge ~waveform/autopkgtest-cloud:publish-optimization into autopkgtest-cloud:master

Proposed by Dave Jones
Status: Merged
Approved by: Iain Lane
Approved revision: 0583abf6d15c7e6013fb523225fd404b4206f9da
Merged at revision: 1d4b453bb69cf2035ec01cbf6da4812bd5aa242a
Proposed branch: ~waveform/autopkgtest-cloud:publish-optimization
Merge into: autopkgtest-cloud:master
Diff against target: 176 lines (+41/-43)
1 file modified
charms/focal/autopkgtest-web/webcontrol/publish-db (+41/-43)
Reviewer Review Type Date Requested Status
Iain Lane Approve
Julian Andres Klode (community) Approve
Review via email: mp+402343@code.qastaging.launchpad.net

Description of the change

Some optimizations for publish-db. Taken as a whole it may look rather a lot, but I've broken each change into its own commit with commentary on what it achieves and why (some are actual performance enhancements, others are cosmetic to make the code a bit easier to maintain in future). I'm happy to rebase and excise bits that aren't wanted / needed.

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

The code changes look ok, and I can't see a regression on autopkgtest.staging.ubuntu.com with this published in edge channel.

review: Approve
Revision history for this message
Iain Lane (laney) wrote :

Cheers. I learned some stuff here, and admittedly some of it I'm taking with a pinch of trust.

Great contribution, looking forward to the same for browse.cgi :D

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches