Code review comment for ~waveform/ubuntu-dev-tools:built-before

Revision history for this message
Dan Streetman (ddstreet) wrote :

> The main reason it doesn't use anything under ubuntutools/ was because, after a quick look through the modules under there I couldn't find anything I needed.

my point is, looking up package versions, like this, sounds like something that could be generally useful for reasons *other* than this, so instead of 'going it alone' in this script, it would be tremendously more useful for you to look at updating ubuntutools to add some kind of interface to do that. then this script can be reduced to minimal param parsing and result formatting, instead of doing *everything* here where no other code can re-use any of it.

I also have concerns about the implementation of get_sources(), using the archive instead of querying LP, why did you decide to do that?

« Back to merge proposal