Ubuntu Images

Merge ~waveform/ubuntu-images:gnome-initial-setup-oracular into ubuntu-images:oracular

  1. Git
  2. lp:~waveform/ubuntu-images
  3. gnome-initial-setup-oracular
  4. Merge into oracular
Proposed by Dave Jones
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: dbc3cb46e8dc88d7103fe5f2d616f5d532a67617
Merged at revision: dbc3cb46e8dc88d7103fe5f2d616f5d532a67617
Proposed branch: ~waveform/ubuntu-images:gnome-initial-setup-oracular
Merge into: ubuntu-images:oracular
Diff against target: 32 lines (+0/-13)
1 file modified
ubuntu-pi-arm64.yaml (+0/-13)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Steve Langasek Needs Information
Michael Hudson-Doyle (community) Approve
Review via email: mp+467828@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Jones (waveform) wrote :

This prepares the Ubuntu oracular desktop for Raspberry Pi images to use gnome-initial-setup for first time user setup instead of oem-config / ubiquity. Please note that this change is not sufficient in an of itself. The other pieces necessary are:

* LP: #2069827 -- place the cloud-init seed on the boot partition
* Changes to the classic pi-gadget to customize the cloud-init seed for the desktop to prevent it from creating an initial user

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

LGTM but I appear not to have write access to this repo!

review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :

so landing this as-is will break the daily images wrt first-boot?

review: Needs Information
Revision history for this message
Dave Jones (waveform) wrote :

Yes, until the pi-gadget changes are made (the cloud-init seed changes have already been made).

The pi-gadget changes are prepped, but while doing so it became increasingly obvious what an unmaintainable complex mess the classic branch was (which is my fault). Hence, I wound up making a considerably simplified variant of the classic branch, which I need to find someone to review first (https://github.com/snapcore/pi-gadget/pull/114).

Revision history for this message
Dave Jones (waveform) wrote :

The pi-gadget changes are now committed so this is the last part that needs to change.

Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches