Release Upgrader

Merge ~waveform/ubuntu-release-upgrader:remove-uboot into ubuntu-release-upgrader:ubuntu/master

  1. Git
  2. lp:~waveform/ubuntu-release-upgrader
  3. remove-uboot
  4. Merge into ubuntu/master
Proposed by Dave Jones
Status: Merged
Merged at revision: 36ed0aa86545ab59e44cb12eea07574f39f36d24
Proposed branch: ~waveform/ubuntu-release-upgrader:remove-uboot
Merge into: ubuntu-release-upgrader:ubuntu/master
Diff against target: 467 lines (+379/-34)
3 files modified
DistUpgrade/DistUpgradeQuirks.py (+137/-1)
debian/changelog (+7/-0)
tests/test_quirks.py (+235/-33)
Reviewer Review Type Date Requested Status
Brian Murray Needs Fixing
Review via email: mp+406663@code.qastaging.launchpad.net

Commit message

Adds a quirk to remote u-boot from the boot sequence of Raspberry Pi installations on impish. This doesn't remove the u-boot binaries themselves, and leaves the actual configuration commented out in the config.txt in case user's wish to revert easily.

LP: #1936401

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I found the function _remove_uboot_on_rpi a bit hard to read and had to scroll up and down multiple times because the file is read, then some other functions are defined, and then the file is passed to those functions. It might be easier for others to read if that was restructured a bit.

I can't really comment on the correctness of the boot config contents but as a release upgrader quirk this seems good to me.

I've some additional comments in-line.

review: Needs Fixing
Revision history for this message
Dave Jones (waveform) wrote :

Added responses to each review comment. Will upload a commit to address the outstanding points.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches