bzr search plugin

Merge lp://qastaging/~weyrick/bzr-search/bzr-search-720853 into lp://qastaging/bzr-search

  1. bzr-search-720853
  2. Merge into trunk
Proposed by Shannon Weyrick
Status: Merged
Merged at revision: 94
Proposed branch: lp://qastaging/~weyrick/bzr-search/bzr-search-720853
Merge into: lp://qastaging/bzr-search
Diff against target: 28 lines (+4/-1)
1 file modified
index.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~weyrick/bzr-search/bzr-search-720853
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) Approve
Review via email: mp+85747@code.qastaging.launchpad.net

Description of the change

Skip bad index keys when BadIndexKey fires from btree_index

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Since there is a bug looming here somewhere, I think the error message should be a warning or at least a note rather than mutter, which isn't visible to th user.

The error message shouldn't say that it's skipping a particular key - it's aborting the indexing entirely. It would also be useful to include the key that was problematic, for debugging purposes.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

and thanks for working on this. I'm voting Needs Fixing for the moment, let me know when I should have another look.

review: Needs Fixing
lp://qastaging/~weyrick/bzr-search/bzr-search-720853 updated
94. By Shannon Weyrick

Switch to warning, include bad key in message, clarify message

Revision history for this message
Shannon Weyrick (weyrick) wrote :

Jelmer, I've made changes based on your comments. I changed the message to "indexing incomplete" because although it does abort it in some sense, it does end up with a usable (i.e. searchable) index.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: