Merge lp://qastaging/~wgrant/launchpad/bug-616154-guessPackageNames-order-fix into lp://qastaging/launchpad/db-devel

Proposed by William Grant
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 9648
Proposed branch: lp://qastaging/~wgrant/launchpad/bug-616154-guessPackageNames-order-fix
Merge into: lp://qastaging/launchpad/db-devel
Diff against target: 45 lines (+23/-1)
2 files modified
lib/lp/registry/model/distribution.py (+2/-1)
lib/lp/soyuz/doc/distribution.txt (+21/-0)
To merge this branch: bzr merge lp://qastaging/~wgrant/launchpad/bug-616154-guessPackageNames-order-fix
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Robert Collins (community) release-critical Approve
Julian Edwards release-critical Pending
Review via email: mp+32285@code.qastaging.launchpad.net

Commit message

Distribution.guessPackageNames once again returns the latest source name for the given binary name.

Description of the change

In the fix for bug #613686, I rewrote the queries used by Distribution.guessPackageNames. For the first query, order was unimportant, so I dropped it -- for the second, however, I failed to notice that the order was critical. As a result, 'libgcc1' now resolves to 'gcc-3.3', rather than 'gcc-4.5' where it is currently built.

This branch returns the BPPH.id DESC sort removed by my last branch, and adds a test for order.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Thanks, rc=lifeless, code change looks fine too.

review: Approve (release-critical)
Revision history for this message
Robert Collins (lifeless) wrote :

Copied Julian FHI.

Revision history for this message
Robert Collins (lifeless) wrote :

Apparently ec2 land has a bug or two :P.

review: Approve
Revision history for this message
Robert Collins (lifeless) wrote :

And so does MP's. grah.

review: Approve (release-critical)
Revision history for this message
Tim Penhey (thumper) :
review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for the fix, although I'm disappointed to see more unit testing inside
a doc test :(

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: