Merge lp://qastaging/~wgrant/launchpad/product-index-code-stab into lp://qastaging/launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 17963 |
| Proposed branch: | lp://qastaging/~wgrant/launchpad/product-index-code-stab |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
337 lines (+116/-79) 3 files modified
lib/lp/registry/stories/product/xx-product-development-focus.txt (+59/-32) lib/lp/registry/stories/product/xx-product-index.txt (+4/-4) lib/lp/registry/templates/product-index.pt (+53/-43) |
| To merge this branch: | bzr merge lp://qastaging/~wgrant/launchpad/product-index-code-stab |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Move branch link, languages and VCS bits of Product:+index to a new "Code" portlet.
Description of the change
Move branch link, languages and VCS bits of Product:+index to a new "Code" portlet.
Now the "Browse the code" link isn't hidden in the middle of a blur of text. The licence section is also now 50% rather than 25% width, eliminating fugly wrapping. And the development focus series edit widget is now in the "Series and milestones" portlet.
I shuffled Bugs and contributors to the right column and FAQs to the left to balance them out a bit more in the common case.
This is preparation for a more minor adjustment to support linking to a default Git repository, not just a Bazaar branch. The increased width in the new portlet will also allow the clone URL to be shown on the project page, shock horror.
http://
http://
| William Grant (wgrant) wrote | # |
To my eye there seems to be a bit of missing spacing above "Version control system" relative to other similar things on the page. Presumably this has something to do with the default CSS for .two-column-list dl:first-child dt, so maybe style="margin-top 0.5em;" there would help.
I can see why you put the questions portlets on the LHS, but I'm not sure I like it. Having them more or less diagonally opposite bugs looks kind of odd, since they're listed in a similar style. Also, putting them on the LHS seems more prominent than they typically deserve; when skimming a page I find my eye scans down the LHS first rather than going across to the middle. And FAQs below questions makes no logical sense at all, since if we have FAQs at all they should appear earlier in the page flow. Perhaps:
Code FAQs
Bugs Questions
Packages Specs
Contributors Sprints
... would be reasonably balanced? Most common collaboration targets at the top left; FAQs above questions; LHS should I think usually come out similar height or slightly higher.
Another logical layout would be more developer-centric stuff on one side, more user-centric stuff on the other. That would yield something like:
Code Packages
Specs Bugs
Sprints FAQs
Contributors Questions
But I'm not convinced that's better, and it might need to be flipped left to right in order to avoid the RHS typically being longer, which decreases the prominence of Code too much for my taste.
The actual patch looks fine, and I definitely like the revamped Code layout; so whatever you pick out of these or your existing layout is OK, and we can always adjust things further later.