Ubuntu
python-oauth package

Merge lp://qastaging/~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral into lp://qastaging/ubuntu/oneiric/python-oauth

  1. Oneiric (11.10)
  2. replace-pycentral
  3. Merge into oneiric
Proposed by Mat Scales
Status: Work in progress
Proposed branch: lp://qastaging/~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Merge into: lp://qastaging/ubuntu/oneiric/python-oauth
Diff against target: 53 lines (+11/-6)
3 files modified
debian/changelog (+7/-0)
debian/control (+3/-5)
debian/rules (+1/-1)
To merge this branch: bzr merge lp://qastaging/~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Disapprove
Ubuntu branches Pending
Review via email: mp+65686@code.qastaging.launchpad.net

Description of the change

Removed the dependency on pycentral, as described at https://wiki.ubuntu.com/BarryWarsaw/PythonHelpers

To post a comment you must log in.
lp://qastaging/~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral updated
8. By Mat Scales

Incorrect release version

9. By Mat Scales

Updated the maintainer

Revision history for this message
Stefano Rivera (stefanor) wrote :

LGTM (as a non-core-dev)

To the sponsor: be aware that there's a newer version of this package in Debian, which has ported to dh_python2 already.

This should probably be merged (and that'll give version number hassles)

Reply
Revision history for this message
Barry Warsaw (barry) wrote :

Hi Mat, thanks very much for your contribution to Ubuntu! As Stefano mentions in the above comment, Debian has a newer version of python-oauth that gives us a new upstream version and switches to dh_python2. Now that Oneiric alpha 2 has been released, this newer version of python-oauth has been sync'd from Debian. We appreciate your help anyway!

Also please let me know if you'd like to work on the conversion for any of the other outstanding packages in bug 788514. You can reach me on #ubuntu-pyjam or #ubuntu-devel on freenode, nick 'barry'.

review: Disapprove
Reply

Unmerged revisions

9. By Mat Scales

Updated the maintainer

8. By Mat Scales

Incorrect release version

7. By Mat Scales

debian/rules, debian/control: Transition to dh_python2 from pycentral
(LP: #788514)

6. By James Westby

Various fixes from Rodney, thanks.

* oauth/oauth.py: Fix typo and argument handling creating invalid
  OAuthRequests with from_consumer_and_token staticmethod().
  (LP: #435994, http://code.google.com/p/oauth/issues/detail?id=117)
* oauth/oauth.py: Fix HMAC-SHA1 verification to follow OAuth Core 1.0 spec
  (LP: #435992, http://code.google.com/p/oauth/issues/detail?id=125)
* New upsream snapshot, includes partial fix for issue 117, and fixes
  an error being raised when no verifier is sent to the server

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: