Merge lp://qastaging/~wiml/libdrizzle/integer-sizes into lp://qastaging/libdrizzle
Proposed by
Wim Lewis
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Andrew Hutchings | ||||||||
| Approved revision: | 121 | ||||||||
| Merged at revision: | 109 | ||||||||
| Proposed branch: | lp://qastaging/~wiml/libdrizzle/integer-sizes | ||||||||
| Merge into: | lp://qastaging/libdrizzle | ||||||||
| Diff against target: |
618 lines (+134/-80) 14 files modified
libdrizzle-5.1/constants.h (+15/-21) libdrizzle-5.1/field_client.h (+17/-2) libdrizzle/binlog.cc (+5/-5) libdrizzle/conn.cc (+6/-0) libdrizzle/field.cc (+36/-18) libdrizzle/handshake.cc (+2/-2) libdrizzle/pack.cc (+19/-7) libdrizzle/pack.h (+2/-1) libdrizzle/result.cc (+10/-8) libdrizzle/result.h (+6/-6) libdrizzle/statement.cc (+1/-1) libdrizzle/statement_param.cc (+8/-2) libdrizzle/structs.h (+6/-6) tests/unit/statement.c (+1/-1) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~wiml/libdrizzle/integer-sizes | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Hutchings | Approve | ||
|
Review via email:
|
|||
Commit message
Adjusting the sizes of integer variables to avoid truncation or overflow; also fixed some errors reading large responses or prepared-statement responses.
Description of the change
This is the result of examining libdrizzle for integer truncation and overflow problems. A few other small bugs were found and fixed along the way--- see the individual commit messages for these.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Very nice catches in there, most of them my silly mistakes, especially around prepared stmt :)
Worst case this slightly breaks API on the drizzle_field functions, but only for 32bit so I'm not so concerned.