Drizzle Client & Protocol Library

Merge lp://qastaging/~wiml/libdrizzle/unit-tests into lp://qastaging/libdrizzle

  1. unit-tests
  2. Merge into libdrizzle-redux
Proposed by Wim Lewis
Status: Merged
Approved by: Andrew Hutchings
Approved revision: no longer in the source branch.
Merged at revision: 110
Proposed branch: lp://qastaging/~wiml/libdrizzle/unit-tests
Merge into: lp://qastaging/libdrizzle
Diff against target: 1326 lines (+1094/-59)
11 files modified
Makefile.am (+1/-0)
libdrizzle/statement.cc (+1/-0)
tests/unit/binlog.cc (+5/-14)
tests/unit/column.c (+11/-31)
tests/unit/common.c (+93/-0)
tests/unit/common.h (+26/-8)
tests/unit/connect_uds.c (+2/-2)
tests/unit/datetypes.c (+330/-0)
tests/unit/include.am (+21/-4)
tests/unit/nulls.c (+278/-0)
tests/unit/numbers.c (+326/-0)
To merge this branch: bzr merge lp://qastaging/~wiml/libdrizzle/unit-tests
Reviewer Review Type Date Requested Status
Andrew Hutchings Approve
Review via email: mp+154480@code.qastaging.launchpad.net

Commit message

Additional unit tests and unit-test cleanup.

Description of the change

Wrote a few more unit tests to cover API I want to use. They currently fail, unfortunately, so I marked them XFAIL. I plan to fix some and file bugs for the rest.

I also rearranged common unit test code a little bit to put it in common.h/common.c, after the discussion in https://code.launchpad.net/~wiml/libdrizzle/unit-tests/+merge/151659 .

To post a comment you must log in.
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Thanks for catching these. If there are any you want me to fix please let me know and I'll try and look over the weekend.

review: Approve
lp://qastaging/~wiml/libdrizzle/unit-tests updated
110. By Drizzle Continuous Integration

Merge lp:~wiml/libdrizzle/unit-tests Build: jenkins-Libdrizzle-75

Revision history for this message
Wim Lewis (wiml-omni) wrote :

There are fixes for some of them in my date-time branch, lp:~wiml-omni/libdrizzle/date-time . I can't justify spending a whole lot more of my employer's time on this, though, so I'm winding down --- I'll be filing a few more bugs w/o fixes probably for someone else to deal with.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: