Gnome Screenshot

Merge lp://qastaging/~woodrow-shen/gnome-screenshot/fix-hidpi.trusty into lp://qastaging/ubuntu/trusty/gnome-screenshot

  1. fix-hidpi.trusty
  2. Merge into trusty
Proposed by Woodrow Shen
Status: Merged
Merge reported by: Iain Lane
Merged at revision: not available
Proposed branch: lp://qastaging/~woodrow-shen/gnome-screenshot/fix-hidpi.trusty
Merge into: lp://qastaging/ubuntu/trusty/gnome-screenshot
Diff against target: 916 lines (+830/-6)
6 files modified
.pc/applied-patches (+1/-0)
.pc/ubuntu_fix_hidpi.patch/src/screenshot-utils.c (+732/-0)
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu_fix_hidpi.patch (+75/-0)
src/screenshot-utils.c (+14/-6)
To merge this branch: bzr merge lp://qastaging/~woodrow-shen/gnome-screenshot/fix-hidpi.trusty
Reviewer Review Type Date Requested Status
Iain Lane Approve
Sebastien Bacher Needs Fixing
Review via email: mp+248486@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Hey Woodrow, thanks for your work on that, some comments:

- is that work coming from upstream? if not could we forward them the change, it's not Ubuntu specific and we would benefit to see it reviewed/commited to the official vcs

- could you describe the change and add urls to the bugs in the patch for reference

- the bug should be fixed in vivid before being SRUed

review: Needs Fixing
Revision history for this message
Woodrow Shen (woodrow-shen) wrote :

Hi Sebastien,

This work isn't from upstream, however I file a bug to bugzilla (see https://bugzilla.gnome.org/show_bug.cgi?id=743957).

So do you mean that basically we always would merge the updates into our package from upstream ?

Revision history for this message
Sebastien Bacher (seb128) wrote :

It's better to have the change reviewed and commited upstream if we can, but it's not a blocker. Thanks for sending it to GNOME

lp://qastaging/~woodrow-shen/gnome-screenshot/fix-hidpi.trusty updated
25. By Woodrow Shen

* debian/patches/ubuntu_fix_hidpi:
 - add the header for patch

26. By Woodrow Shen

* debian/patches/ubuntu_fix_hidpi:
 - fix the header for patch

Revision history for this message
Woodrow Shen (woodrow-shen) wrote :

Got it, so let the upstream review this patch, thanks your help.

Revision history for this message
Iain Lane (laney) wrote :

Upstream seems to be mostly inactive, uploaded to Ubuntu now. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: