Merge lp://qastaging/~woodrow-shen/unity-greeter/fix-hidpi-support into lp://qastaging/unity-greeter/14.04

Proposed by Woodrow Shen
Status: Needs review
Proposed branch: lp://qastaging/~woodrow-shen/unity-greeter/fix-hidpi-support
Merge into: lp://qastaging/unity-greeter/14.04
Diff against target: 552 lines (+148/-38)
10 files modified
src/cairo-utils.vala (+27/-0)
src/dash-box.vala (+8/-4)
src/dash-button.vala (+3/-1)
src/dash-entry.vala (+8/-3)
src/greeter-list.vala (+13/-8)
src/list-stack.vala (+2/-1)
src/main-window.vala (+4/-1)
src/menubar.vala (+14/-2)
src/prompt-box.vala (+26/-9)
src/shutdown-dialog.vala (+43/-9)
To merge this branch: bzr merge lp://qastaging/~woodrow-shen/unity-greeter/fix-hidpi-support
Reviewer Review Type Date Requested Status
Robert Ancell Needs Fixing
Review via email: mp+242311@code.qastaging.launchpad.net

Description of the change

The fix can scale menubar, prompt-box, and shutdown-dialog box according to gnome hidpi rules from https://wiki.gnome.org/HowDoI/HiDpi. so I just added hidpi checking into cairo-utils for temporary. But icons on menubar seem that it's hard to scale even if I used to re-scale by gtk.image. Besides, the scale factor is fixed to 2 for hidpi condition.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

The use of DashEntry.font is a bug and there are a number of style changes to fix.

review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

Could you also consider to use the patch of https://bugs.launchpad.net/ubuntu/+source/unity-greeter/+bug/1286878/comments/8 for unity-settings-daemon and avoid the duplicated works of HiDPI display checking?

1208. By Woodrow Shen

Fix the some code style.

1209. By Woodrow Shen

Fix the correct space number without tab.

Unmerged revisions

1209. By Woodrow Shen

Fix the correct space number without tab.

1208. By Woodrow Shen

Fix the some code style.

1207. By Woodrow Shen

Use get_hidpi_scale function to replace hard-code.

1206. By Woodrow Shen

This patch try to fix the problem that unity-greeter can't scale on a hidpi display.
Currenly the icons on menubar still don't work, and sometimes menuitem may unchanged
unexpectedly.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches