Merge lp://qastaging/~xanderfomin/midori/fix-bug1258849 into lp://qastaging/midori

Proposed by Alexander Fomin
Status: Work in progress
Proposed branch: lp://qastaging/~xanderfomin/midori/fix-bug1258849
Merge into: lp://qastaging/midori
Diff against target: 149 lines (+40/-12)
5 files modified
katze/katze-utils.c (+16/-0)
midori/midori-preferences.c (+9/-3)
midori/midori-settings.vala (+1/-1)
midori/midori-view.c (+8/-8)
midori/midori-view.h (+6/-0)
To merge this branch: bzr merge lp://qastaging/~xanderfomin/midori/fix-bug1258849
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
Review via email: mp+220736@code.qastaging.launchpad.net

Description of the change

Changing default zoom representation from float value to percent.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

There's a flaw here: any existing values already stored in user config files will be wrong after this change and anyone programatically dealing with it will be up for a surprise. So I'd rather this were a strictly UI related solution. This already hard-codes "zoom" as a special-case so it may as well deal with 1.0 being 100%?

review: Needs Fixing

Unmerged revisions

6706. By Alexander Fomin

Changing default zoom representation from float to percent.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: