Ubuntu
mailman package

Merge lp://qastaging/~xav0989/ubuntu/vivid/mailman/ubuntu-logo into lp://qastaging/ubuntu/vivid/mailman

  1. Vivid (15.04)
  2. ubuntu-logo
  3. Merge into vivid
Proposed by Xavier L.
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp://qastaging/~xav0989/ubuntu/vivid/mailman/ubuntu-logo
Merge into: lp://qastaging/ubuntu/vivid/mailman
Diff against target: 1605 lines (+1554/-3)
6 files modified
.pc/81_ubuntu_logo.patch/Mailman/Defaults.py.in (+1527/-0)
.pc/applied-patches (+1/-0)
Mailman/Defaults.py.in (+3/-3)
debian/changelog (+7/-0)
debian/patches/81_ubuntu_logo.patch (+15/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~xav0989/ubuntu/vivid/mailman/ubuntu-logo
Reviewer Review Type Date Requested Status
Iain Lane Disapprove
Barry Warsaw Pending
Review via email: mp+242453@code.qastaging.launchpad.net

Description of the change

This patch simply replaces the "Debian Powered" text and logo with the text "Powered by Ubuntu" and the Ubuntu logo.

To post a comment you must log in.
Revision history for this message
Xavier L. (xav0989) wrote :

Well, I just realized that mailman has failed importing since 2012... -> http://package-import.ubuntu.com/status/mailman.html

Revision history for this message
Iain Lane (laney) wrote :

Hey Barry, want to review this? Looks like it'll still apply despite comment #1

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Honestly, mailman doesn't have any other Ubuntu delta. It doesn't seem reasonable to me to create one just to change the Powered logo and text. This will result in unnecessary ongoing merge maintenance.

Revision history for this message
Sebastien Bacher (seb128) wrote :

that could maybe go to Debian with some dpkg-vendor hackery or distro specific quilt serie?

Revision history for this message
Iain Lane (laney) wrote :

I think we would not want to take on the ongoing effort of manually merging mailman every release (as would be required if we took this patch).

Could you please submit it to Debian? seb128 suggests that you can do this by running dpkg-vendor to detect if we are building on Ubuntu or Debian and modify the source accordingly - I think this is the way to go. See /usr/share/dpkg/vendor.mk & don't hesitate to come to #ubuntu-motu on IRC if you need help.

Thanks for your work so far. :)

review: Disapprove

Unmerged revisions

40. By Xavier L.

Add patch 81_ubuntu_logo to switch the 'Debian Powered' text to
'Powered by Ubuntu'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: