Merge lp://qastaging/~xavi-garcia-mena/go-unityscopes/go-subsearch into lp://qastaging/go-unityscopes/v2
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~xavi-garcia-mena/go-unityscopes/go-subsearch |
| Merge into: | lp://qastaging/go-unityscopes/v2 |
| Prerequisite: | lp://qastaging/~xavi-garcia-mena/go-unityscopes/find-list-child-scopes |
| Diff against target: |
1200 lines (+922/-32) 16 files modified
metadata_test.go (+2/-2) reply.cpp (+46/-0) reply.go (+51/-4) result.cpp (+9/-0) result.go (+12/-0) scope.cpp (+6/-1) shim.h (+3/-0) tests/aggregated/aggregated.go (+141/-0) tests/aggregated/aggregated.ini.in (+16/-0) tests/aggregated/aggregated_test.py (+269/-0) tests/aggregated/simple-scope-2.ini.in (+16/-0) tests/aggregated/simple-scope.ini.in (+16/-0) tests/goscope/goscope.go (+2/-22) tests/simple-scope-2/simple-scope-2.go (+157/-0) tests/simple-scope/simple-scope.go (+157/-0) unityscope.go (+19/-3) |
| To merge this branch: | bzr merge lp://qastaging/~xavi-garcia-mena/go-unityscopes/go-subsearch |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kyle Fazzari (community) | Approve | ||
| James Henstridge | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
This branch adds full functionality to implement aggregated scopes in go.
It implements the subsearch method from SearchQueryBase.
The branch also includes scope-harness to verify aggregated scopes.
Description of the change
This branch adds full functionality to implement aggregated scopes in go.
It implements the subsearch method from SearchQueryBase.
The branch also includes scope-harness to verify aggregated scopes.
| Xavi Garcia (xavi-garcia-mena) wrote | # |
Unmerged revisions
- 84. By Xavi Garcia
-
added suggested changes
- 83. By Xavi Garcia
-
Added Finished method to SearchListener. Some functions moved from goscope.go to reply.go.
- 82. By Xavi Garcia
-
Removed SetSearchReply and GetSearchReply from the subsearch listener, as they are no longer needed
- 81. By Xavi Garcia
-
Moved subsearch method to SeachReply. Working version
- 80. By Xavi Garcia
-
Moved Subsearch to SearchReply. Passed go fmt to the test files. NOTE: This branch is still work in progress, it's not fully functional
- 79. By Xavi Garcia
-
Removed binary
- 78. By Xavi Garcia
-
Hide wait mechanism for child scopes to the developer. Now Aggregated scopes wait by default transparently
- 77. By Xavi Garcia
-
Removed some comments
- 76. By Xavi Garcia
-
Fixed typo and removed commented include
- 75. By Xavi Garcia
-
Added Subsearch method to retrieve results from child scopes. Added scope-harness tests for aggregated scopes
I've left some inline comments. The main conceptual problem I see is tying the Subsearch API to the ScopeBase class, with other issues stemming from that (e.g. the WaitGroup on ScopeBase).