Merge lp://qastaging/~xavi-garcia-mena/go-unityscopes/gomock-example into lp://qastaging/go-unityscopes/v2
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~xavi-garcia-mena/go-unityscopes/gomock-example |
| Merge into: | lp://qastaging/go-unityscopes/v2 |
| Prerequisite: | lp://qastaging/~xavi-garcia-mena/go-unityscopes/replies-interfaces |
| Diff against target: |
727 lines (+600/-12) 10 files modified
category.go (+25/-0) result.cpp (+5/-0) result.go (+8/-0) shim.h (+2/-1) testing.cpp (+13/-0) tests/goscope/fake_reply.go (+48/-0) tests/goscope/goscope.go (+3/-2) tests/goscope/goscope_test.go (+292/-0) tests/goscope/reply_moc.go (+204/-0) unityscope.go (+0/-9) |
| To merge this branch: | bzr merge lp://qastaging/~xavi-garcia-mena/go-unityscopes/gomock-example |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kyle Fazzari (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added some examples about testing scopes with the new reply interfaces.
Description of the change
Added some examples about testing scopes with the new reply interfaces.
Also exposed new testing category.
Unmerged revisions
- 86. By Xavi Garcia
-
Added test creating own fake SearchReply
- 85. By Xavi Garcia
-
Added a test using gomock. Exposed a testing Category
- 84. By Xavi Garcia
-
Moved PreviewReply and SearchReply to be interfaces and make it possible to be mocked
- 83. By Xavi Garcia
-
Added Finished method to SearchListener. Some functions moved from goscope.go to reply.go.
- 82. By Xavi Garcia
-
Removed SetSearchReply and GetSearchReply from the subsearch listener, as they are no longer needed
- 81. By Xavi Garcia
-
Moved subsearch method to SeachReply. Working version
- 80. By Xavi Garcia
-
Moved Subsearch to SearchReply. Passed go fmt to the test files. NOTE: This branch is still work in progress, it's not fully functional
- 79. By Xavi Garcia
-
Removed binary
- 78. By Xavi Garcia
-
Hide wait mechanism for child scopes to the developer. Now Aggregated scopes wait by default transparently
- 77. By Xavi Garcia
-
Removed some comments
This looks good to me-- definitely makes mocking/faking easier.