The Sound Menu

Merge lp://qastaging/~xavi-garcia-mena/indicator-sound/lp-1478506-use-role-volume into lp://qastaging/indicator-sound/15.10

lp-1478506-use-role-volume
Merge into trunk.15.10

Proposed by Xavi Garcia on 2015-08-13

Status:

Needs review

Proposed branch:

lp://qastaging/~xavi-garcia-mena/indicator-sound/lp-1478506-use-role-volume

Merge into:

lp://qastaging/indicator-sound/15.10

Diff against target:

95 lines (+45/-11)

1 file modified

src/volume-control-pulse.vala (+45/-11)

To merge this branch:

bzr merge lp://qastaging/~xavi-garcia-mena/indicator-sound/lp-1478506-use-role-volume

High

Confirmed

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-08-13
Charles Kerr		2015-08-13	Pending
Review via email: mp+267985@code.qastaging.launchpad.net

Commit message

Adding changes to use the current role volume instead of getting it from pulse.

Description of the change

Adding changes to use the current role volume instead of getting it from pulse.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-13:

PASSED: Continuous integration, rev:501
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/238/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/14
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/14/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/238/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-08-13:

Thanks for working on that, I'm just curious but what's the issue with getting it from pulse? Is pulse giving a wrong information? If so why?

Revision history for this message

Xavi Garcia (xavi-garcia-mena) wrote on 2015-08-17:

Hi Sebastien,

At that point, and only for the "Maroon in trouble" game, I get 100% volume even it is using the multimedia role and that we had set a different volume for that role previously.
For other apps the volume obtained is correct.

I don't know if it has relation with the fact that the sounds played are very short...

I've opened a bug to see if we can get a response.

https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1485522