The Sound Menu

Merge lp://qastaging/~xavi-garcia-mena/indicator-sound/show-microphone-volume-external-mic into lp://qastaging/indicator-sound/15.10

  1. show-microphone-volume-external-mic
  2. Merge into trunk.15.10
Proposed by Xavi Garcia
Status: Merged
Approved by: Xavi Garcia
Approved revision: 540
Merged at revision: 532
Proposed branch: lp://qastaging/~xavi-garcia-mena/indicator-sound/show-microphone-volume-external-mic
Merge into: lp://qastaging/indicator-sound/15.10
Prerequisite: lp://qastaging/~xavi-garcia-mena/indicator-sound/last-running-player-accounts-service
Diff against target: 447 lines (+300/-41)
4 files modified
src/volume-control-pulse.vala (+31/-2)
tests/integration/indicator-sound-test-base.cpp (+101/-39)
tests/integration/indicator-sound-test-base.h (+6/-0)
tests/integration/test-indicator.cpp (+162/-0)
To merge this branch: bzr merge lp://qastaging/~xavi-garcia-mena/indicator-sound/show-microphone-volume-external-mic
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+287928@code.qastaging.launchpad.net

Commit message

Add changes to show up the microphone controls when an external microphone is detected.

Description of the change

This branch adds changes to show up the microphone controls when an external microphone is detected.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:538
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/319/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/94
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/95
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/95/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/319/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM. One optional suggestion inline.

review: Approve
Revision history for this message
Charles Kerr (charlesk) wrote :

Oh, and one question: why no tests?

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Thanks for the review, Charles.
I've added that function.

I'm already working on tests...

I need to find out how to add some pulseaudio logic in order to test sources with certain properties.

We'll need also to add sinks using the microphone, simulating a fake client recording audio...

As we are already testing sink outputs I don't think sinks are going to be an issue.

I hope to finish that soon.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:540
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/320/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/95
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/96
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/96/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/320/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches