lp://qastaging/~xavi-garcia-mena/thumbnailer/more-downloaders-unit-tests

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

148. By Xavi Garcia on 2015-05-01

Added unit tests for downloaders

147. By Xavi Garcia on 2015-05-01

Fake server modified to add returning 404 code when the file we try to read is not found, also erased some imports and methods that were not used

146. By Xavi Garcia on 2015-05-01

Added unit tests for dbus using fake server.
Also includes modification in fake server to return binary data.

Approved by James Henstridge, PS Jenkins bot.

145. By Xavi Garcia on 2015-04-30

Fixed data being truncated.
Added workaround to avoid adding the "album" prefix to the album name.

Approved by PS Jenkins bot, James Henstridge.

144. By Xavi Garcia on 2015-04-30

This branch is not expected to be merged as includes changes not fully working.

Approved by PS Jenkins bot, James Henstridge.

143. By Michi Henning on 2015-04-29

Changed code to cache full-size images only if the are remote or, if they are local, if they are inside and audio or video container. Otherwise, we use the local image file directly and don't cache it.

Approved by PS Jenkins bot, James Henstridge.

142. By Michi Henning on 2015-04-29

Made write_file() atomic using rename(). Added some tests for file_io functions.

Approved by PS Jenkins bot, James Henstridge.

141. By Michi Henning on 2015-04-29

make_directories() now uses g_mkdir_with_parents().

Approved by PS Jenkins bot, James Henstridge.

140. By James Henstridge on 2015-04-29

Scale images while loading them, and use the EXIF thumbnail if it is at least as large as the requested size.

Add sample images in all 8 EXIF orientations for use in the test suite.

Approved by PS Jenkins bot, Michi Henning.

139. By Michi Henning on 2015-04-28

Use new cache for local thumbnails. This is poor in regression tests, but has reasonably good coverage. For now, I've tested thumbnail extraction manually by saving retrieved thumbnails and inspecting them by hand. Will add more tests that are more rigorous next.

Approved by PS Jenkins bot, James Henstridge, Michi Henning.