Launchpad itself

Merge ~xnox/launchpad:drop-i18n-index into launchpad:master

Proposed by Dimitri John Ledkov on 2023-10-14

Status:	Needs review
Proposed branch:	~xnox/launchpad:drop-i18n-index
Merge into:	launchpad:master
Diff against target:	185 lines (+67/-4) 9 files modified lib/lp/archivepublisher/publishing.py (+5/-4) lib/lp/archivepublisher/tests/test_publisher.py (+23/-0) lib/lp/registry/configure.zcml (+1/-0) lib/lp/registry/interfaces/distroseries.py (+11/-0) lib/lp/registry/model/distroseries.py (+10/-0) lib/lp/registry/stories/webservice/xx-distroseries.rst (+1/-0) lib/lp/registry/tests/test_distroseries.py (+11/-0) lib/lp/soyuz/scripts/initialize_distroseries.py (+3/-0) lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py (+2/-0)
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Julian Andres Klode (community)	2023-10-14	Approve on 2023-10-23
Ubuntu Package Archive Administrators	2023-10-14	Pending
Launchpad code reviewers	2023-10-14	Pending
Review via email: mp+453586@code.qastaging.launchpad.net

Commit message

Add a new option to turn off i18n/Index file publishing

It is not signed, it contains SHA-1 hashes which apt doesn't trust anymore, and it is believed to be unused by apt, as it finds the underlying translation files from the the InRelease file.

Intention is to turn publishing i18n index file off during 24.04 release development

Revision history for this message

William Grant (wgrant) wrote on 2023-10-14:

Tools like debmirror used to use this. Have we confirmed that other common tools handling apt repositories no longer do?

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2023-10-14:

Doing it via toggle is one way to find out.

Also since this index is sha1 based, it no longer is secure. Any mirroring must use InRelease file and strong hashes.

And given strong hashes of these files exist in the InRelease, it is wasteful to repeat them.

Also, sort of hoping to maybe have this merged and sample published on qastaging or some such, and publish a PPA there to allow checking against a real thing.

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2023-10-14:

http://ftp.debian.org/debian/dists/bookworm/main/i18n/

Debian does not publish Index.

Reading debmirror code it can get them either via Release file, or via i18n/Index and I think tries both always.

And since it works for Debian, surely it works for us to drop it too.

Revision history for this message

Julian Andres Klode (juliank) wrote on 2023-10-23:

I concur with xnox

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.