Merge lp://qastaging/~yeban/libmemcached/todo-hosts.c-2 into lp://qastaging/~tangent-org/libmemcached/trunk

Proposed by Anuarg Priyam
Status: Merged
Approved by: Brian Aker
Approved revision: 934
Merged at revision: 947
Proposed branch: lp://qastaging/~yeban/libmemcached/todo-hosts.c-2
Merge into: lp://qastaging/~tangent-org/libmemcached/trunk
Diff against target: 28 lines (+7/-3)
1 file modified
libmemcached/hosts.c (+7/-3)
To merge this branch: bzr merge lp://qastaging/~yeban/libmemcached/todo-hosts.c-2
Reviewer Review Type Date Requested Status
Libmemcached-developers Pending
Review via email: mp+57121@code.qastaging.launchpad.net

Description of the change

Second attempt at addressing a marked TODO in hosts.c - check return type of memcached_server_create_with in server_add, and remove a bogus TODO marker.

To post a comment you must log in.
Revision history for this message
Anuarg Priyam (yeban) wrote :

Maybe memcached_set_error is not needed, as server_add is mostly an intermediate call.

Revision history for this message
Brian Aker (brianaker) wrote :

Merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: