Merge lp://qastaging/~yolanda.robla/heat/icehouse_add_heatclient into lp://qastaging/~ubuntu-server-dev/heat/icehouse

Proposed by Yolanda Robla
Status: Merged
Approved by: Chuck Short
Approved revision: 29
Merged at revision: 28
Proposed branch: lp://qastaging/~yolanda.robla/heat/icehouse_add_heatclient
Merge into: lp://qastaging/~ubuntu-server-dev/heat/icehouse
Diff against target: 34 lines (+6/-1)
2 files modified
debian/changelog (+5/-1)
debian/control (+1/-0)
To merge this branch: bzr merge lp://qastaging/~yolanda.robla/heat/icehouse_add_heatclient
Reviewer Review Type Date Requested Status
Chuck Short (community) Needs Fixing
Review via email: mp+197579@code.qastaging.launchpad.net

Description of the change

Added heatclient to test requirements.

To post a comment you must log in.
Revision history for this message
Chuck Short (zulcss) wrote :

This is wrong, the python-heatclient needs to be added to the debian/control not the test_requirements.txt

review: Needs Fixing
29. By Yolanda Robla

debian/control: Added python-heatclient as a build dependency.

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Ok, problem is that for me builds locally, so I patched a bit supposing the failure. Moved python-heatclient as build dependency.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches