Ubuntu
dovecot package

Merge lp://qastaging/~yolanda.robla/ubuntu/saucy/dovecot/update_dovecot_name into lp://qastaging/ubuntu/saucy/dovecot

  1. Saucy (13.10)
  2. update_dovecot_name
  3. Merge into saucy
Proposed by Yolanda Robla
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp://qastaging/~yolanda.robla/ubuntu/saucy/dovecot/update_dovecot_name
Merge into: lp://qastaging/ubuntu/saucy/dovecot
Diff against target: 130 lines (+87/-1)
5 files modified
debian/changelog (+9/-0)
debian/control (+3/-1)
debian/patches/dovecot_name.patch (+73/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp://qastaging/~yolanda.robla/ubuntu/saucy/dovecot/update_dovecot_name
Reviewer Review Type Date Requested Status
Martin Pitt Approve
James Page Pending
Review via email: mp+170071@code.qastaging.launchpad.net

Description of the change

Updated dovecot name

To post a comment you must log in.
lp://qastaging/~yolanda.robla/ubuntu/saucy/dovecot/update_dovecot_name updated
99. By Yolanda Robla

updated description

Revision history for this message
Martin Pitt (pitti) wrote :

dovecot_autoreconf.patch is going to be really hard to maintain. May I suggest dropping this and using dh_autoreconf instead?

++AC_DEFINE_UNQUOTED(DOVECOT_NAME, "$PACKAGE_NAME$DOVECOT_DISTRIBUTION", Dovecot name)

Shouldn't there be a space between the package name and the distro name?

review: Needs Fixing
lp://qastaging/~yolanda.robla/ubuntu/saucy/dovecot/update_dovecot_name updated
100. By Yolanda Robla

debian/rules: added autoconf in config-stamp

101. By Yolanda Robla

updated dependencies

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Removed dovecot_autoreconf.patch, and calling autoconf in debian/rules
Space not needed between $PACKAGE_NAME and $DOVECOT_DISTRIBUTION, because that space is added when setting the $DOVECOT-DISTRIBUTION var. By this way, no extra space is added if $DOVECOT_DISTRIBUTION is empty.

Revision history for this message
Martin Pitt (pitti) wrote :

Looks much better, thanks!

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

As you didn't bzr add the changed source and quilt files, and I always mess this up as well, I just uploaded this and let the package importer sort it out. Closing MP manually. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: