Merge lp://qastaging/~yugiohjcj/inkscape/yugiohjcj-inkscape into lp://qastaging/~inkscape.dev/inkscape/trunk

Proposed by YuGiOhJCJ
Status: Needs review
Proposed branch: lp://qastaging/~yugiohjcj/inkscape/yugiohjcj-inkscape
Merge into: lp://qastaging/~inkscape.dev/inkscape/trunk
Diff against target: 68 lines (+9/-7)
3 files modified
CMakeLists.txt (+5/-3)
CMakeScripts/HelperMacros.cmake (+2/-2)
src/CMakeLists.txt (+2/-2)
To merge this branch: bzr merge lp://qastaging/~yugiohjcj/inkscape/yugiohjcj-inkscape
Reviewer Review Type Date Requested Status
Bryce Harrington (community) code Approve
Review via email: mp+318991@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM

review: Approve (code)

Unmerged revisions

15566. By YuGiOhJCJ
15565. By YuGiOhJCJ

* CMakeLists.txt: use the "CMAKE_INSTALL_LIBDIR" variable instead of a hard-coded "lib" string.
* CMakeScripts/HelperMacros.cmake: use the "CMAKE_INSTALL_LIBDIR" variable instead of a hard-coded "lib" string.
* src/CMakeLists.txt: use the "CMAKE_INSTALL_LIBDIR" variable instead of a hard-coded "lib" string.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.