qtcreator-plugin-ubuntu

Merge lp://qastaging/~zeller-benjamin/qtcreator-plugin-ubuntu/1362439 into lp://qastaging/qtcreator-plugin-ubuntu

  1. 1362439
  2. Merge into trunk
Proposed by Benjamin Zeller
Status: Rejected
Rejected by: Zoltan Balogh
Proposed branch: lp://qastaging/~zeller-benjamin/qtcreator-plugin-ubuntu/1362439
Merge into: lp://qastaging/qtcreator-plugin-ubuntu
Diff against target: 227 lines (+0/-212)
2 files modified
share/qtcreator/ubuntu/menu.json (+0/-11)
share/qtcreator/ubuntu/scripts/local_get_cordova_runtime (+0/-201)
To merge this branch: bzr merge lp://qastaging/~zeller-benjamin/qtcreator-plugin-ubuntu/1362439
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Maxim Ermilov Pending
Zoltan Balogh Pending
Review via email: mp+234666@code.qastaging.launchpad.net

Commit message

support for using cordova api from unity-webapps-qml was deprecated,
remove unused menu item and script

Description of the change

support for using cordova api from unity-webapps-qml was deprecated,
remove unused menu item and script:

<zaspire> zbenjamin: we deprecated support for using cordova api from unity-webapps-qml. So best solution would be removing any mention about cordova from qtcreator-plugin-ubuntu
<zbenjamin> zaspire: ah ok, so we can remove that item from the menu.json
<zaspire> zbenjamin: it will be great ;)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:286
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/422/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-amd64-ci/190
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-armhf-ci/190

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/422/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Barth (dbarth) wrote :

This is a correct change, yes. But do not apply that change until the rest of the plan is implemented. I will hold on approving this branch for now, to avoid this being merged in by mistake <grin> ;)

Unmerged revisions

286. By Benjamin Zeller

support for using cordova api from unity-webapps-qml was deprecated,
remove unused menu item and script

285. By Benjamin Zeller

Merge

284. By Benjamin Zeller

Make sure the .ssh directory has the right owner and permissions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches