PulseAudio

Merge lp://qastaging/~zequence/pulseaudio/module-jackdbus-detect-channel-config into lp://qastaging/~ubuntu-audio-dev/pulseaudio/ubuntu

  1. module-jackdbus-detect-channel-config
  2. Merge into ubuntu
Proposed by Kaj Ailomaa
Status: Merged
Merge reported by: David Henningsson
Merged at revision: not available
Proposed branch: lp://qastaging/~zequence/pulseaudio/module-jackdbus-detect-channel-config
Merge into: lp://qastaging/~ubuntu-audio-dev/pulseaudio/ubuntu
Diff against target: 170 lines (+133/-0)
5 files modified
debian/changelog (+12/-0)
debian/patches/0022-module-jackdbus-detect-channel-config-default.patch (+14/-0)
debian/patches/0108-module-jackdbus-detect-channel-config.patch (+78/-0)
debian/patches/0109-module-jackdbus-detect-channel-config-fix.patch (+27/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp://qastaging/~zequence/pulseaudio/module-jackdbus-detect-channel-config
Reviewer Review Type Date Requested Status
David Henningsson Approve
Review via email: mp+149827@code.qastaging.launchpad.net

Description of the change

Add channel configuration for module-jackdbus-detect and set the default to 2, as jack is not well adapted for anything beyond mono or stereo connections (i.e. 5.1, 7.1 and similar are difficult to use with jack).

To post a comment you must log in.
Revision history for this message
David Henningsson (diwic) wrote :

Hi and thanks for your merge proposal,

I'm wondering about "0022-module-jackdbus-detect-channel-config-default.patch" - isn't 2 already the default if no channels argument is specified?

review: Needs Information
Revision history for this message
Kaj Ailomaa (zequence) wrote :

It'll create as many channels as there are channels on the audio device
that jack is running.
So, if there are 8 I/O on the audio device, the module will create a 7.1
interface for it with labels like "left", "right", "front", "back", etc.
If more than 8, instead of being called "left", "right", "front", etc in
the PA interface, you get "aux0", "aux1"..
If there are only 2 I/O, then the module creates a stereo interface.

So, making sure the module always uses a stereo interface by default
should help integrate PA easier with jack, as jack thinks more in terms of
multiple mono channels.

On Thu, 21 Feb 2013 23:08:17 +0100, David Henningsson
<email address hidden> wrote:

> Review: Needs Information
>
> Hi and thanks for your merge proposal,
>
> I'm wondering about
> "0022-module-jackdbus-detect-channel-config-default.patch" - isn't 2
> already the default if no channels argument is specified?

Revision history for this message
Kaj Ailomaa (zequence) wrote :

On Fri, 22 Feb 2013 01:06:59 +0100, Kaj Ailomaa <email address hidden>
wrote:

> If more than 8, instead of being called "left", "right", "front", etc in
> the PA interface, you get "aux0", "aux1"..

..on top of the existing "left", "right", "front"

Revision history for this message
David Henningsson (diwic) wrote :

Well, if a user has a 5.1 card, and wants to use JACK with it and PulseAudio on top of that, is there something wrong with providing a sink with a channel map for all six channels that matches that? I'm not following.

Revision history for this message
Kaj Ailomaa (zequence) wrote :

I think the case when someone wants to use 5.1 is much rarer than using
stereo. I also think of this solution as a temporary one, one which I
believe most jack users will prefer, as most jack users use stereo
monitoring for audio production.

It would be best if one could choose a profile for the jack sink and
source from the PA mixer, as you can for devices (I guess those are based
on alsa vard profiles?).

Revision history for this message
Kaj Ailomaa (zequence) wrote :

Or, for rather, a profile for the output. The input I don't really know how that should work, what PA is considered.

Revision history for this message
David Henningsson (diwic) :
review: Approve
Revision history for this message
David Henningsson (diwic) wrote :

Merged and uploaded, thanks for your contribution!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches