Merge lp://qastaging/~zeroincombenze/openobject-italia/7.0 into lp://qastaging/~openobject-italia-core-devs/openobject-italia/italian-addons-7.0
Proposed by
Antonio M. - Zeroincombenze
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~zeroincombenze/openobject-italia/7.0 | ||||
| Merge into: | lp://qastaging/~openobject-italia-core-devs/openobject-italia/italian-addons-7.0 | ||||
| Diff against target: |
51 lines (+12/-7) 3 files modified
l10n_it_partially_deductible_vat/AUTHORS.txt (+3/-2) l10n_it_partially_deductible_vat/__openerp__.py (+1/-1) l10n_it_partially_deductible_vat/account.py (+8/-4) |
||||
| To merge this branch: | bzr merge lp://qastaging/~zeroincombenze/openobject-italia/7.0 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Davide Corio (community) | code review, no test | Approve | |
| Lorenzo Battistini | code review | Approve | |
|
Review via email:
|
|||
Commit message
[FIX] Bug #1335867 Randomly Tax has diff. rates
Description of the change
Added new check condition
To post a comment you must log in.
Revision history for this message
| Antonio M. - Zeroincombenze (zeroincombenze) wrote | # |
Revision history for this message
| Davide Corio (enlightx-deactivatedaccount) | # |
review:
Approve
(code review, no test)
Revision history for this message
| Lorenzo Battistini (elbati) wrote | # |
Unmerged revisions
- 241. By openerp <openerp@shs-av-dev>
-
[FIX] Bug #1335867 Randomly Tax has diff. rates
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Bug #1335867
Randomly, software report follow wrong error message:
"The taxes %s have different rates"
As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate.
The last one has type = 'balance' in order to receive all residual amount.
The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded.