Merge lp://qastaging/~zestoi/mixxx/spinback_brake into lp://qastaging/~mixxxdevelopers/mixxx/trunk

Proposed by Zestoi
Status: Merged
Merged at revision: 3212
Proposed branch: lp://qastaging/~zestoi/mixxx/spinback_brake
Merge into: lp://qastaging/~mixxxdevelopers/mixxx/trunk
Diff against target: 188 lines (+104/-11)
2 files modified
mixxx/src/controllers/controllerengine.cpp (+99/-8)
mixxx/src/controllers/controllerengine.h (+5/-3)
To merge this branch: bzr merge lp://qastaging/~zestoi/mixxx/spinback_brake
Reviewer Review Type Date Requested Status
RJ Skerry-Ryan Approve
Review via email: mp+107526@code.qastaging.launchpad.net

Description of the change

implements a spinback/brake effect in the engine

new function: ControllerEngine::brake() to enable/disable the effect

modified function: ControllerEngine::scratchProcess()

* m_rampFactor[deck] variable instead of 0.0001 constant
* extra logic to work out when the scratch timer can be disabled
* m_brakeActive[deck] to store whether we are in this effect or normal scratching mode
* m_brakeKeylock[deck] to store the keylock status so we can disable for the effect and re-enable afterwards if we need to

To post a comment you must log in.
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

LGTM -- thanks zestoi!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches