Merge lp://qastaging/~zhangew401/scope-aggregator/fix-empty-query-to-clickstore into lp://qastaging/scope-aggregator
Proposed by
Zhang Enwei
Status: | Merged |
---|---|
Approved by: | Zhang Enwei |
Approved revision: | 171 |
Merged at revision: | 171 |
Proposed branch: | lp://qastaging/~zhangew401/scope-aggregator/fix-empty-query-to-clickstore |
Merge into: | lp://qastaging/scope-aggregator |
Diff against target: |
90 lines (+23/-36) 2 files modified
src/query.cpp (+17/-14) src/utils.cpp (+6/-22) |
To merge this branch: | bzr merge lp://qastaging/~zhangew401/scope-aggregator/fix-empty-query-to-clickstore |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kyle Nitzsche (community) | Approve | ||
Gary.Wang | Pending | ||
Review via email:
|
Description of the change
In r170, when query_store_ is empty, some random scopes will be recommended, we need to fix this.
Also fix comments from Gary.
To post a comment you must log in.
Looks good to me.
Cheers