Merge lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1524597 into lp://qastaging/scope-aggregator
Status: | Merged |
---|---|
Approved by: | Kyle Nitzsche |
Approved revision: | 171 |
Merged at revision: | 170 |
Proposed branch: | lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1524597 |
Merge into: | lp://qastaging/scope-aggregator |
Diff against target: |
137 lines (+89/-1) 4 files modified
CMakeLists.txt (+1/-1) README.md (+57/-0) include/query.h (+1/-0) src/utils.cpp (+30/-0) |
To merge this branch: | bzr merge lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1524597 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary.Wang | Needs Fixing | ||
Kyle Nitzsche (community) | Approve | ||
Penk Chen | Pending | ||
Review via email:
|
Description of the change
In order to fix lp:1524597, I introduced key "sources" for "scope" key.
This key could only be set for "com.canonical.
[...]
"scope":
{
"id": "com.canonical.
{
},
{
},
{
},
{
},
{
}
]
}
[...]
This is only useful for aggregators that only use "keyword" to aggregate child scopes. For declared scopes, if some declared scope is not installed, you can easily use above example without "sources" key to inform the user to download missing declared scopes from the store.
Hi Gary,
The README.md now says this applies to scopes aggregated by keyword (because it previously worked for scopes aggregated by scope ID).
Question: How does it work for an aggregator scope that includes both:
* scopes aggregated by scope ID
* scopes aggregated by keyword
Does the child_scopes.json dev *only* need to add scope ID for keyword scopes to the new "sources" list because scopes aggregated by scope ID will already display?
Or when this "sources" key is present, does it completed supersede the previous behavior (which would mean the dev would need to add *both* scopes agg'd by scope id and by keyword?