Code review comment for lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1524597

Revision history for this message
Zhang Enwei (zhangew401) wrote :

Thanks Kyle.
Sorry for the confusion.
1. If both two kinds of scopes exist in child_scopes.json, it will collect missing scopes in both kinds and show to the end user.
2. For you question, "Does the child_scopes.json dev *only* need to add scope ID for keyword scopes to the new "sources" list because scopes aggregated by scope ID will already display?"
   Yes.

« Back to merge proposal