lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1604212
- Get this branch:
- bzr branch lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1604212
Branch merges
- Kyle Nitzsche (community): Approve
- Gary.Wang: Approve
- Penk Chen: Pending requested
-
Diff: 38 lines (+11/-5)2 files modifiedCMakeLists.txt (+1/-1)
src/utils.cpp (+10/-4)
Related bugs
Bug #1604212: child_department in category->scopes doesn't work | Critical | Fix Released |
Related blueprints
Branch information
Recent revisions
- 165. By Gary.Wang
-
1.compile time optimization for string(
QStringLiteral) .
2.load the various json files once aggregator scope startup.
3.specify 'const' keyword for some variable in some cases.
4.pass by reference instead of by value if possible.
5.don't allocated memory(make_shared) based on local variable to avoid copy constructor.
6 remove duplicate obj creation.
7.fix invalid pointer for us::Category::SCPtr when look_up is called.
8.remove redundant files. - 164. By Kyle Nitzsche
-
scope-agg projects no longer require a separate hints child scope to
provide quick start help or to provide the no netork of the no location
message. All scopes rebasing on 4.8 must change their hints.json file
since the structure is now chagned.See 4.8-rebase-
local-hints- README. md for complete details. - 163. By Kyle Nitzsche
-
merge branch with many changes:
* in handle_child_scope_ results( ), check if the query is still
valid. If not, then return.
* do not save ptrs to categories. Instead, use from shell if already registered, else register and then use it from shell.
* feature testing with some new parts and some fixes - 161. By Gary.Wang
-
1.Fix duplicated scope ids issue(lp:1554411) which blocks child scopes search)
2.Fix compiler warning - 160. By Kyle Nitzsche
-
Merge that works withi/requires 1.0 version of hints scope as follows:
Previously when hints quickstart displayed and user tapped "Skip" button
the hints scope set the uri on the Skip button result like so:
scope://com.canonical. scopes. dashboard_ dashbiard? q=start The result was that the "start" string displayed in the agg scope search
box, which is not great.The agg scope looked for an incoming query string of "start" and if found
it treated it as signal to dismiss hints quick start (by writing a file
to cache dir, a file that is checked on every refresh).This merge changes the expectation of the agg scope as follows:
The signal to dismiss hints now takes the form of user_data of
"hide_quickstart" in the incoming uri, for example:
std::string data = query().user_data( ).get_string( );
if (data == "hide_quickstart")
... then write the file to dismiss hints. - 159. By Kyle Nitzsche
-
use actual runtime id of agg scope in those log messages that were not
previously using them, fixing lp:1549844
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/scope-aggregator