Merge lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1604212 into lp://qastaging/scope-aggregator

Proposed by Zhang Enwei
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 168
Merged at revision: 168
Proposed branch: lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1604212
Merge into: lp://qastaging/scope-aggregator
Diff against target: 38 lines (+11/-5)
2 files modified
CMakeLists.txt (+1/-1)
src/utils.cpp (+10/-4)
To merge this branch: bzr merge lp://qastaging/~zhangew401/scope-aggregator/fix-lp-1604212
Reviewer Review Type Date Requested Status
Kyle Nitzsche (community) Approve
Gary.Wang Approve
Penk Chen Pending
Review via email: mp+300406@code.qastaging.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks for this merge proposal.
It looks good to me.

P.S.
I think this issue was introduced by this MP
https://code.launchpad.net/~gary-wzl77/scope-aggregator/4.8-opt
Sorry.

review: Approve
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

LGTM - thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: