Merge ~zhsj/ubuntu/+source/kmod:merge-20230519 into ubuntu/+source/kmod:debian/sid

Proposed by Shengjing Zhu
Status: Needs review
Proposed branch: ~zhsj/ubuntu/+source/kmod:merge-20230519
Merge into: ubuntu/+source/kmod:debian/sid
Diff against target: 813 lines (+596/-1)
10 files modified
debian/changelog (+457/-0)
debian/control (+2/-1)
debian/depmod.d/ubuntu.conf (+1/-0)
debian/modprobe.d/blacklist-ath_pci.conf (+7/-0)
debian/modprobe.d/blacklist-firewire.conf (+10/-0)
debian/modprobe.d/blacklist-framebuffer.conf (+31/-0)
debian/modprobe.d/blacklist-rare-network.conf (+22/-0)
debian/modprobe.d/blacklist.conf (+52/-0)
debian/modprobe.d/iwlwifi.conf (+7/-0)
debian/rules (+7/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt (community) Approve
git-ubuntu import Pending
Review via email: mp+446138@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Shengjing Zhu (zhsj) wrote :
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

The old upload already had split history, so comparison of the retained delta is easy.
$ git range-diff zhsj/import/30+20221128-1..pkg/import/30+20221128-1ubuntu1 pkg/import/30+20230519-1..zhsj/merge-20230519

It shows that the applied changes are just the same we had on top of the old.
Going through all sanity checks

* Changelog:
  - [+] old content and logical tag match as expected
  - [+] changelog entry correct version and targeted codename
  - [+] changelog entries correct
  - [n/a] bug references correct
  - [+] update-maintainer has been run

* Merge - Indirect Changes:
  - [+] no upstream changes that need adaptation
  - [+] no further upstream version to consider (nothing newer than this on https://github.com/kmod-project/kmod/commits/master)
  - [n/a] debian changes look safe (there are none)

* Merge - Old Delta:
  - [n/a] dropped changes are ok to be dropped
  - [+] nothing else to drop
  - [n/a] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [+] no new patches added

* Git/Maintenance
  - [+] commits are properly split (more important on -dev than on SRUs)

* Build/Test:
  - [+] build is ok (PPA only had x86 though)
  - [+] verified PPA package installs/uninstalls
  - [+] autopkgtest against the PPA package passes
  - [+] sanity checks test fine

review: Approve
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

Since some tarball access complained I double checked if there was any fould trickery with the version, but all seems fine:
  $ dpkg --compare-versions "30+20230519-1ubuntu1" gt "30+20221128-1ubuntu1"

Other foundations merges have tracking bugs, I can sponsor without.
But how about your team process, should I next time insist on one?

---

$ dput ubuntu kmod_30+20230519-1ubuntu1_source.changes
Uploading kmod using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running suite-mismatch: check the target distribution for common errors
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
running required-fields: check whether a field is present and non-empty in the changes file
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running nobug: Stop if uploading without any bug reference.
WARNING: No bugs marked as closed!
Check: Upload without bug references? [yes, NO]: yes
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running checksum: verify checksums before uploading
running gpg: check GnuPG signatures before the upload
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running check-debs: makes sure the upload contains a binary package
Uploading kmod_30+20230519-1ubuntu1.dsc
Uploading kmod_30+20230519-1ubuntu1.debian.tar.xz
Uploading kmod_30+20230519-1ubuntu1_source.buildinfo
Uploading kmod_30+20230519-1ubuntu1_source.changes

Revision history for this message
Shengjing Zhu (zhsj) wrote (last edit ):

@paelzer I asked on Mattermost, and Michael said foundations team doesn't have requirement for tracking bug. Actually I don't think we have documented required rules...

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches