Ubuntu Community Accomplishments

Merge lp://qastaging/~zilvador/ubuntu-community-accomplishments/chat-on-irc into lp://qastaging/ubuntu-community-accomplishments

  1. chat-on-irc
  2. Merge into trunk
Proposed by Daniel Ejsing-Duun
Status: Merged
Merged at revision: 239
Proposed branch: lp://qastaging/~zilvador/ubuntu-community-accomplishments/chat-on-irc
Merge into: lp://qastaging/ubuntu-community-accomplishments
Diff against target: 131 lines (+112/-0)
4 files modified
accomplishments/ubuntu-community/en/general/chat-on-irc.accomplishment (+22/-0)
accomplishments/ubuntu-community/extrainformation/irc-nickname (+9/-0)
scripts/ubuntu-community/general/chat-on-irc.py (+76/-0)
tests/ubuntu-community/general/chat-on-irc (+5/-0)
To merge this branch: bzr merge lp://qastaging/~zilvador/ubuntu-community-accomplishments/chat-on-irc
Reviewer Review Type Date Requested Status
Matt Fischer Approve
Review via email: mp+138013@code.qastaging.launchpad.net

Description of the change

Added the accomplishment Chat on irc, which checks if the user has chatted a few times today or yesterday on any Ubuntu IRC channel. Note that an extra field is also added to the identification window with IRC name.

To post a comment you must log in.
Revision history for this message
Matt Fischer (mfisch) wrote :

A few corrections/questions:

- meaningless is one word, no hyphen
- I think this accomplishment needs signing perhaps?
- move the pitfall that you need to be in an ubuntu channel to the Steps section (which I think you need to add)
- In your test case the failure result should be something that will fail for sure, like a made up email

Do you have a list of logged channels? You may need to have a link that points to the official list.

review: Needs Fixing
Revision history for this message
Daniel Ejsing-Duun (zilvador) wrote :

Corrections done. I think I would like to make a few updates on the accomplishments creation guide if I may :).

> Do you have a list of logged channels? You may need to have a link that points
> to the official list.

I used https://wiki.ubuntu.com/IRC/ChannelList so far and added a note that most channels are considered for the accomplishment. The actual list are the logs on http://irclogs.ubuntu.com/, but I'm not sure it looks 'pretty' enough to show new users. Waiting for comment ont his before pushing changes.

Revision history for this message
Matt Fischer (mfisch) wrote :

+1 on the channel list, the rest we're discussing on IRC

lp://qastaging/~zilvador/ubuntu-community-accomplishments/chat-on-irc updated
234. By Daniel Ejsing-Duun

Corrected search string and programming mistake, added signing and corrected test file

Revision history for this message
Matt Fischer (mfisch) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: