Ubuntu UI Toolkit

Merge lp://qastaging/~zsombi/ubuntu-ui-toolkit/theming-attached into lp://qastaging/ubuntu-ui-toolkit/staging

theming-attached
Merge into staging

Proposed by Zsombor Egri on 2015-07-29

Status:	Rejected
Rejected by:	Cris Dywan on 2015-10-08
Proposed branch:	lp://qastaging/~zsombi/ubuntu-ui-toolkit/theming-attached
Merge into:	lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target:	777 lines (+379/-209) 9 files modified components.api (+2/-1) src/Ubuntu/Components/plugin/plugin.cpp (+2/-1) src/Ubuntu/Components/plugin/plugin.pri (+4/-2) src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+21/-184) src/Ubuntu/Components/plugin/ucstyleditembase.h (+1/-3) src/Ubuntu/Components/plugin/ucstyleditembase_p.h (+7/-14) src/Ubuntu/Components/plugin/uctheme.cpp (+4/-4) src/Ubuntu/Components/plugin/ucthemingattached.cpp (+257/-0) src/Ubuntu/Components/plugin/ucthemingattached.h (+81/-0)
To merge this branch:	bzr merge lp://qastaging/~zsombi/ubuntu-ui-toolkit/theming-attached
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-08-06
Cris Dywan		2015-07-29	Approve on 2015-07-30
Review via email: mp+266317@code.qastaging.launchpad.net

Commit message

Detaching theming management from StyledItem to be reused in other cpp types.

Revision history for this message

Zsombor Egri (zsombi) wrote on 2015-07-30:

StyledItem was registered twice with the revision 2, so the 1.3 appeared twice in the API file. I fixed that as well.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-30:

FAILED: Continuous integration, rev:1583
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2071/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/799/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/801/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/798/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2071/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~zsombi/ubuntu-ui-toolkit/theming-attached updated on 2015-07-30

1584. By Zsombor Egri on 2015-07-30: segfault fixed

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-30:

FAILED: Continuous integration, rev:1584
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2073/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/801
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/803
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/803/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/800

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/2073/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2015-07-30:

As discussed, there is no effective change in functionality in StyledItemBase so it's already covered by unit tests. We won't really know if it exposes the theming correctly until we have the first real word user of it, which is going to be the Label in C++ which can't currently inherit from StyledItemBase, so this should be the prerequisite branch.

review: Approve

lp://qastaging/~zsombi/ubuntu-ui-toolkit/theming-attached updated on 2015-08-05